Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#264] pubsub #321

Merged
merged 35 commits into from
Jul 31, 2024
Merged

[#264] pubsub #321

merged 35 commits into from
Jul 31, 2024

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Jul 26, 2024 •
edited
Loading

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #264

elBoberido and others added 14 commits July 26, 2024 18:52
@elBoberido @elfenpiff
[eclipse-iceoryx#210] Add publisher and subscriber builder
d88187b
@elBoberido @elfenpiff
[eclipse-iceoryx#210] Create subscriber
6552285
@elBoberido @elfenpiff
[eclipse-iceoryx#210] Create publisher
4a9abf1
@elfenpiff
[eclipse-iceoryx#264] Add port factory publisher
a7907cc
@elfenpiff
[eclipse-iceoryx#264] Implement port factory subscriber
6fd15bb
@elfenpiff
[eclipse-iceoryx#264] Implement cxx publisher
49862ab
@elfenpiff
[eclipse-iceoryx#264] Implement cxx subscriber
b16d31b
@elfenpiff
[eclipse-iceoryx#264] Implement cxx publisher send copy
7ca62a8
@elBoberido @elfenpiff
[eclipse-iceoryx#210] Add functionality to receive samples
19e92ae
@elfenpiff
[eclipse-iceoryx#264] Fix publisher slice len issue with custom paylo…
2a2787e 
…ad message type details
@elfenpiff
[eclipse-iceoryx#264] Implement cxx sample
3ff3ce6
@elfenpiff
[eclipse-iceoryx#264] Integrate cxx sample into subscriber
cdd0dc8
@elfenpiff
[eclipse-iceoryx#264] Integrate cxx sample into subscriber
47ca92d
@elfenpiff
[eclipse-iceoryx#264] Add c/cxx sample_mut
166fc5e
@elfenpiff elfenpiff self-assigned this Jul 26, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.53%. Comparing base (51b57b6) to head (28870cb).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   80.46%   80.53%   +0.06%     
==========================================
  Files         192      192              
  Lines       22426    22442      +16     
==========================================
+ Hits        18046    18073      +27     
+ Misses       4380     4369      -11
Files Coverage Δ
iceoryx2/src/port/publisher.rs 84.71% <100.00%> (+0.42%) ⬆️

... and 9 files with indirect coverage changes

@elfenpiff elfenpiff force-pushed the iox2-264-pubsub branch 2 times, most recently from 2a72907 to e1c71c0 Compare July 27, 2024 18:43
@elfenpiff elfenpiff marked this pull request as ready for review July 28, 2024 15:25
elBoberido
elBoberido reviewed Jul 29, 2024
View reviewed changes
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the examples and a few of the files with only small changes.

examples/c/event/src/listener.c Show resolved Hide resolved
examples/c/event/src/listener.c Show resolved Hide resolved
iceoryx2-ffi/cxx/include/iox2/port_factory_publisher.hpp Show resolved Hide resolved
iceoryx2/src/port/publisher.rs Outdated Show resolved Hide resolved
elBoberido
elBoberido reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything from cxx reviewed. Now only 7 files from ffi are left.

iceoryx2-ffi/cxx/include/iox2/port_factory_subscriber.hpp Show resolved Hide resolved
iceoryx2-ffi/cxx/include/iox2/publisher.hpp Outdated Show resolved Hide resolved
iceoryx2-ffi/ffi/src/api/message_type_details.rs Show resolved Hide resolved
iceoryx2-ffi/cxx/include/iox2/sample_mut.hpp Show resolved Hide resolved
iceoryx2-ffi/cxx/include/iox2/sample.hpp Outdated Show resolved Hide resolved
@elfenpiff elfenpiff force-pushed the iox2-264-pubsub branch 2 times, most recently from 8bbb07a to b790594 Compare July 31, 2024 08:21
elBoberido
elBoberido reviewed Jul 31, 2024
View reviewed changes
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only a few small things

iceoryx2-ffi/ffi/src/api/publisher.rs Outdated Show resolved Hide resolved
iceoryx2-ffi/ffi/src/api/publisher.rs Outdated Show resolved Hide resolved
iceoryx2-ffi/ffi/src/api/sample_mut.rs Outdated Show resolved Hide resolved
@elfenpiff elfenpiff merged commit ed7d689 into eclipse-iceoryx:main Jul 31, 2024
45 of 46 checks passed
@elfenpiff elfenpiff deleted the iox2-264-pubsub branch July 31, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elBoberido elBoberido elBoberido approved these changes

Assignees

@elfenpiff elfenpiff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elfenpiff @elBoberido